DEVDOCS RUBY UPGRADE

Users/simon/src/devdocs/lib/docs/storage/abstract_store.rb:182:in `track_touched' Users/simon/src/devdocs/lib/docs/storage/abstract_store.rb:87:in `block (2 levels) in replace' Users/simon/src/devdocs/lib/docs/core/doc.rb:115:in `block in store_pages' Users/simon/src/devdocs/lib/docs/core/scraper.rb:76:in `build_pages' Users/simon/src/devdocs/lib/docs/core/scrapers/url_scraper.rb:38:in `request_all' Users/simon/src/devdocs/lib/docs/core/requester.rb:18:in `run' Users/simon/src/devdocs/lib/docs/core/requester.rb:57:in `handle_response' Users/simon/src/devdocs/lib/docs/core/requester.rb:58:in `block in handle_response' Users/simon/src/devdocs/lib/docs/core/requester.rb:58:in `each' Users/simon/src/devdocs/lib/docs/core/requester.rb:59:in `block (2 levels) in handle_response' Users/simon/src/devdocs/lib/docs/core/scraper.rb:77:in `block in build_pages' Users/simon/src/devdocs/lib/docs/core/scraper.rb:159:in `handle_response' Users/simon/src/devdocs/lib/docs/core/scraper.rb:160:in `block in handle_response' Users/simon/src/devdocs/lib/docs/core/scraper.rb:179:in `process_response' Users/simon/src/devdocs/lib/docs/filters/core/images.rb:23:in `call' Users/simon/src/devdocs/lib/docs/filters/core/images.rb:38:in `block in call' Users/simon/src/devdocs/lib/docs/core/request.rb:13:in `run' Users/simon/src/devdocs/lib/docs/core/request.rb:26:in `run' Users/simon/src/devdocs/lib/docs/core/instrumentable.rb:15:in `instrument'

Users/simon/src/devdocs/lib/docs/core/request.rb:27:in `block in run' Users/simon/src/devdocs/lib/docs/filters/core/images.rb:69:in `block (2 levels) in call' NameError: uninitialized constant Docs::ImagesFilter::Base64 Svgo worker: `svgo` not found please provide proper binary or disable this worker (-no-svgo argument or `:svgo => false` through options) exception when reading /Users/simon/src/devdocs/.image_optim.yml: Tried to load unspecified class: Range > bundle exec thor docs:generate -force -package react Let me know if there are any questions or anything else I can help with. I did add one more change that is for asdf users, pretty straight-forward, just something I missed on the first pass.

Failure to do this could would almost certainly prevent the app from starting and we'd need to roll back to the 2.7.6 version Whoever deploys this in heroku will need to set up the buildpack for 3.1.2, it's one of the 3 currently supported ruby buildpacks. There is one more thing that I want to make sure is sorted. The recommended replacement is dart-sass but that seems well out of scope for this set of changes. Other than that the docker builds look good to me, although I am still new to this codebase. This is coming from sprockets-sass which is EOL. Use keyword argument like ERB.new(str, trim_mode. usr/local/bundle/gems/sprockets-3.7.2/lib/sprockets/erb_processor.rb:21: warning: Passing trim_mode with the 3rd argument of ERB.new is deprecated. Do not use it, and specify other arguments as keyword arguments. usr/local/bundle/gems/sprockets-3.7.2/lib/sprockets/erb_processor.rb:21: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. DidYouMean is built-in to the language now so the deprecation will happen in lockstep with a future version.įor now it looks like we are fine until ruby 3.3:

DEVDOCS RUBY UPGRADE

Push comes to shove we can convert these to rake tasks, it wouldn't be a huge lift and we'd already be doing another ruby upgrade to get ourselves into that situation. We can pull in the new version whenever they cut it, I'm sure the rails team is aware of it. There is some movement on main but I think this is on that group of maintainers to resolve. I've bumped us to the latest which is 1.2.1 where the issue still exists: That said, they're warnings and the app seemed to function just fine. Neither of those are present when using ruby 2. home/oliver/.rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/sprockets-3.7.2/lib/sprockets/erb_processor.rb:21: warning: Passing safe_level with the 2nd argument of ERB.new is deprecated. Please call `rrect_error(error_name, spell_checker)' instead. Calling `DidYouMean::SPELL_rge!(error_name => spell_checker)' has been deprecated.

Devdocs ruby